kgabryje commented on code in PR #22474:
URL: https://github.com/apache/superset/pull/22474#discussion_r1065850309
##########
superset-frontend/src/dashboard/components/gridComponents/Column.jsx:
##########
@@ -58,6 +59,50 @@ const propTypes = {
const defaultProps = {};
+const ColumnStyles = styled.div`
+ &.grid-column {
+ width: 100%;
+ position: relative;
+
+ & > :not(.hover-menu):not(:last-child) {
+ margin-bottom: ${({ theme }) => theme.gridUnit * 4}px;
+ }
+ }
+
+ &.grid-column--empty {
+ min-height: ${({ theme }) => theme.gridUnit * 25}px;
+
+ &:before {
+ content: 'Empty column';
Review Comment:
We need to move that text out of `::before` as simply doing `content:
${t('Empty column')};` doesn't work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
