rusackas commented on code in PR #22474:
URL: https://github.com/apache/superset/pull/22474#discussion_r1067202426
##########
superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx:
##########
@@ -57,6 +59,28 @@ type AceEditorWrapperProps = {
hotkeys: HotKey[];
};
+const StyledAceEditor = styled(AceEditor)`
+ ${({ theme }) => css`
+ && {
+ //double class is better than !important
+ border: 1px solid ${theme.colors.grayscale.light2};
+ font-feature-settings: 'liga' off, 'calt' off;
+ // Fira Code causes problem with Ace under Firefox
+ font-family: 'Menlo', 'Consolas', 'Courier New', 'Ubuntu Mono',
Review Comment:
We should probably make a follow-up PR that changes the global font, and
still use the global one here, if Fira is problematic. Design folks might have
opinions here, but I'll bet consistency is the most important thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
