[GitHub] [superset] kgabryje commented on pull request #22502: fix: Adjust useChildElementTruncation to eliminate infinite loop issue

[GitBox]

kgabryje commented on PR #22502:
URL: https://github.com/apache/superset/pull/22502#issuecomment-1378967948

   > I noticed 1 small problem - according to requirements for the truncation 
logic, `+x` shouldn't include items that are partially visible. For example, if 
we have `item1, item2, item3` and we display `item1, ite...`, we should display 
+1, not +2. Currently it looks like we include that partially visible item in 
the counter (see screenshot) <img alt="image" width="165" 
src="https://user-images.githubusercontent.com/15073128/211846849-fa037acf-6a9b-46a1-a3ef-8552385981a2.png";>
   
   UPDATE: it seems to be flaky :( When I first open the filter card it says 
`+2`, when I try a few more times it changes to `+3`
   
   
https://user-images.githubusercontent.com/15073128/211848402-b6683f6a-8091-4736-ab3b-041d4f388769.mov
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org