kgabryje opened a new pull request, #22937:
URL: https://github.com/apache/superset/pull/22937

   ### SUMMARY
   When user applied a time range native filter, the filter would not call 
"unfocus" action (in Chrome) or "unhover" action (in Safari) which caused the 
charts not in scope of that filter to stay greyed out.
   This PR fixes that behaviour by manually calling those actions after 
clicking "Save" or "Cancel" buttons in the time range modal.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   
https://user-images.githubusercontent.com/15073128/216053067-b16c17fd-aad2-4c64-aa26-1502e56890e9.mov
   
   After:
   
   
https://user-images.githubusercontent.com/15073128/216053089-413e25a8-75ef-48d2-ae84-eaa2b14ee41c.mov
   
   ### TESTING INSTRUCTIONS
   1. Add 2 charts compatible with time filters to a dashboard
   2. Add a time range filter that has only 1 of added charts in scope
   3. Set the filter and close the modal
   4. Verify that both charts are not greyed out
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to