Always-prog commented on code in PR #20078:
URL: https://github.com/apache/superset/pull/20078#discussion_r1093627017
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx:
##########
@@ -24,7 +24,11 @@ import { PivotData, flatKey } from './utilities';
import { Styles } from './Styles';
const parseLabel = value => {
- if (typeof value === 'number' || typeof value === 'string') {
+ if (typeof value === 'string') {
+ if (value === 'metric') return t('metric');
Review Comment:
Where did you receive information that the messages.json files need to be
refactored with Prettier? As I understand it, they can be pushed as builded.
And your previous commits with changed messages.json passed all tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
