Always-prog commented on code in PR #20078:
URL: https://github.com/apache/superset/pull/20078#discussion_r1093674195
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx:
##########
@@ -24,7 +24,11 @@ import { PivotData, flatKey } from './utilities';
import { Styles } from './Styles';
const parseLabel = value => {
- if (typeof value === 'number' || typeof value === 'string') {
+ if (typeof value === 'string') {
+ if (value === 'metric') return t('metric');
Review Comment:
I builded your mo files on my and found that after building everything is
fine. With or without Prettier refactoring, there are no warnings.
However, the messages.json files that you pushed are still getting warnings
from Prettier on my. Can you please check your translation using the `npm run
check-translation` command on your computer before pushing and make it works?
Maybe you don't need to refactor messages.json by prettier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
