jfrag1 commented on code in PR #22931:
URL: https://github.com/apache/superset/pull/22931#discussion_r1100781471
##########
superset/datasets/commands/create.py:
##########
@@ -47,6 +48,7 @@ def run(self) -> Model:
dataset = DatasetDAO.create(self._properties, commit=False)
# Updates columns and metrics from the dataset
dataset.fetch_metadata(commit=False)
+ create_table_permissions(dataset)
Review Comment:
Oh you're right, I'm assuming that `create_table_permissions` came before
that function but wasn't removed once `dataset_after_insert` made it
unnecessary. I've removed that function entirely now, let me know if we should
keep it though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
