hughhhh commented on code in PR #22853:
URL: https://github.com/apache/superset/pull/22853#discussion_r1114912927
##########
superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx:
##########
@@ -61,7 +61,7 @@ export type ExploreQuery = QueryResponse & {
};
export interface ISimpleColumn {
- name?: string | null;
+ column_name?: string | null;
Review Comment:
since we are condensing `Query` to use the `TableColumn` model object we
need make the names match
https://github.com/apache/superset/blob/f2b512f0dc8514509953e67fb70faacf92868a92/superset/connectors/base/models.py#L602
Before we were managing our on dict inside extra, and I made is `name`
originally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
