hughhhh commented on code in PR #22853:
URL: https://github.com/apache/superset/pull/22853#discussion_r1115648077
##########
tests/integration_tests/charts/data/api_tests.py:
##########
@@ -1203,8 +1203,8 @@ def test_chart_cache_timeout_chart_not_found(
[
(200, {"where": "1 = 1"}),
(200, {"having": "count(*) > 0"}),
- (400, {"where": "col1 in (select distinct col1 from
physical_dataset)"}),
- (400, {"having": "count(*) > (select count(*) from
physical_dataset)"}),
+ (403, {"where": "col1 in (select distinct col1 from
physical_dataset)"}),
+ (403, {"having": "count(*) > (select count(*) from
physical_dataset)"}),
Review Comment:
So not 100% sure why this started firing but if you follow the codepath for
this test specifically for `subquery_not_allowed` we should of been logging 403
from the start.
[where the check is
happening](https://sourcegraph.com/github.com/apache/superset/-/blob/superset/models/helpers.py?L124)
[exception
defintion](https://sourcegraph.com/github.com/apache/superset/-/blob/superset/exceptions.py#L165)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
