villebro opened a new pull request, #23319:
URL: https://github.com/apache/superset/pull/23319

   ### SUMMARY
   Currently filter cascading is only supported on value filters. This adds 
cascading to time and numerical filters. Since the time column control is now 
shared between the dependent filter and pre-filter sections, it will render the 
time column picker in either section that is relevant.
   
   ### VIDEO
   Demo of how time filters can now cascade:
   
   
https://user-images.githubusercontent.com/33317356/224089182-5e3ff108-e595-4787-ab7f-5cffb5ab416e.mp4
   
   Value filter affecting numerical range:
   
   
https://user-images.githubusercontent.com/33317356/224090635-5fcf9189-631b-458e-bb9b-74881c0b16ff.mp4
   
   ### TESTING INSTRUCTIONS
   1. Add a time filter and value filter
   2. Make the value filter dependent on the time filter
   3. Notice how changing the time filter affects the value filter
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to