villebro commented on code in PR #23319:
URL: https://github.com/apache/superset/pull/23319#discussion_r1132452344
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ColumnSelect.tsx:
##########
@@ -84,10 +83,7 @@ export function ColumnSelect({
);
useEffect(() => {
- if (
- currentColumn &&
- !doesColumnMatchFilterType(currentFilterType, currentColumn)
- ) {
+ if (currentColumn && !filterValues(currentColumn)) {
Review Comment:
This was causing the time column select to fail on numerical range filter,
as it validated that the selected column was numerical (obviously not the case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
