justinpark opened a new pull request, #23329:
URL: https://github.com/apache/superset/pull/23329
### SUMMARY
Hotfix for #21895
The existing `merge(defaultSchema, htmlSchemaOverrides)` replaces the array
item rather than appending, so override item can pollute the default schema
configuration.
For example:
```
const htmlSchemaOverrides = {
tagNames: ['iframe'],
}
- with `merge(defaultSchema, htmlSchemaOverrides)
==> ['iframe', 'h2', 'h3', 'h4', ...]
- with this hotfix
==> ['h1', 'h2', 'h3', 'h4', ..., 'iframe']
```
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TESTING INSTRUCTIONS
- Add custom `tagNames` items in `HTML_SANITIZATION_SCHEMA_EXTENSIONS` and
then create markdown h1
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
cc: @etr2460 @michael-s-molina @ktmud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
