justinpark commented on PR #23329:
URL: https://github.com/apache/superset/pull/23329#issuecomment-1466547300
> LGTM but `getOverrideHtmlSchema` looks more like a private function of the
`SafeMarkdown` module, especially since it uses a library specific
schema----which means we should test the behavior of `SafeMarkdown` instead to
make the unit tests more future-proof.
>
> Not a big deal though.
I agree with the idea but superset-ui-core doesn't accept the
testing-library yet. Therefore I setup the minimum test spec to verify the
regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
