michael-s-molina commented on code in PR #23547:
URL: https://github.com/apache/superset/pull/23547#discussion_r1155836648
##########
superset-frontend/src/dashboard/components/SliceAdder.jsx:
##########
@@ -302,6 +357,25 @@ class SliceAdder extends React.Component {
placeholder={t('Sort by')}
/>
</Controls>
+ <div
+ css={theme => css`
+ display: flex;
+ flex-direction: row;
+ justify-content: center;
+ padding: 0 ${theme.gridUnit * 3}px ${theme.gridUnit * 3}px
+ ${theme.gridUnit * 3}px;
+
+ & > span {
+ margin-right: ${theme.gridUnit}px;
+ }
+ `}
+ >
+ <Checkbox
+ onChange={this.onAccessibleCharts}
+ checked={this.state.showAccessibleCharts}
+ />
+ {t('Show other charts I have access to')}
Review Comment:
You're right. "other" does look like a complement and it should be the union.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
