michael-s-molina commented on PR #23547: URL: https://github.com/apache/superset/pull/23547#issuecomment-1494184352
> In terms of styling: > > * let's align the checkbox to the left > * (I think) let's bump the spacings between search and checkbox and thumbnails to 16px to give it more breathing space Will do! > In terms of behavior: I am wondering if having a control that would say "Show my charts only" wouldn't be a better /more intuitive approach as we would start with the big list with all the possibilities, that you just narrow with the filter checkbox. I think "Show my charts only" is an interesting suggestion and maybe even easier to understand than "Show all charts I have access to". @john-bodley did a similar suggestion but in his scenario, "Show my charts only" would be selected by default and the user could uncheck it. The advantage is this point: > The reason for showing user charts by default is because it's more likely they will interact with their own charts and also for performance reasons, as we don't need to load all the metadata associated with a big number of charts upfront. > We could also add a tooltip with information about this whole thing "By default, the chart list displays all charts that you have access to in the workspace. You can filter the list to show only charts that you own." Great idea. The tooltip will be helpful. > Also - is the selection you made in the checkbox saved for the future or you have to click each time? Currently, it's not persisted but I think it's a great idea because it would allow us to default to user charts but give them the option to change this default. @villebro @kasiazjc @john-bodley In summary, are you all ok with changing the checkbox to "Show my charts only" , which is checked by default, has a tooltip, and persists its state in the local storage so users can change it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
