michael-s-molina opened a new pull request, #23588:
URL: https://github.com/apache/superset/pull/23588

   ### SUMMARY
   Changes the Email report functionality in Explore to behave in the same way 
as the dashboards and only allow editing after a chart is saved. Previously, 
the user could try to setup an email report but would face many errors because 
many parts of the feature depend on the saved state.
   
   It improves rendering by returning the same instance of an empty `report`, 
used in `useEffect`, when there's none in the Redux store.
   
   It also creates an specific `DELETE_REPORT` action to clearly separate the 
logic and avoid unnecessary queries.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
https://user-images.githubusercontent.com/70410625/230118876-cbb050af-76e3-4655-95c2-84a03b0172d2.mov
   
   
https://user-images.githubusercontent.com/70410625/230118976-71ed8fd9-c308-4c9b-b522-1798c307fee3.mov
   
   ### TESTING INSTRUCTIONS
   Check the videos for instructions.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to