justinpark opened a new pull request, #23669:
URL: https://github.com/apache/superset/pull/23669

   ### SUMMARY
   If you have an existing sqllab browser tab open and for whatever reason get 
disconnected from the vpn and issue a query, that query tab will forever be 
suck in a "running/pending" state and fail to stop.
   The issue is that the query request never reaches the server; whereas, it is 
recorded in local storage.
   This commit adds the clearInactiveQuery action to clean up the queries that 
never connected with the server and then batches the action on QueryAutoRefresh 
logic.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   After:
   
   
https://user-images.githubusercontent.com/1392866/231591678-14ec6386-b79b-4e19-8ff4-c7a4781165a7.mov
   
   Before:
   
   
https://user-images.githubusercontent.com/1392866/231591629-3326300f-3e29-4a49-b9ae-565a557000e8.mov
   
   
   ### TESTING INSTRUCTIONS
   - Set `SQLLAB_BACKEND_PERSISTENCE` False
   - Go to SQLLab
   - Disconnect network after SQL Lab fully loaded
   - Run an any query and then close the browser
   - Reconnect internet and then open SQL Lab 
   - Check the query result status
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to