Antonio-RiveroMartnez opened a new pull request, #23715:
URL: https://github.com/apache/superset/pull/23715

   ### SUMMARY
   There might be times where after changing the dataset, the `translateToSql` 
is not just a string but an object and thus you get an error when trying to 
perform the substring operation. In that case we need to get the label from the 
`column_name` if present if not just return an empty string instead.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
![error](https://user-images.githubusercontent.com/38889534/232602461-2b3fef28-44a2-49a1-ac2d-01bed6bce8b3.png)
   
   After:
   
![test](https://user-images.githubusercontent.com/38889534/232603574-d13dd959-27fb-4dad-87a1-ae1ab5229439.gif)
   
   
   
   ### TESTING INSTRUCTIONS
   1. Load a BigNumber chart
   2. Swap the dataset to be something that has a time filter like Vehicle 
Sales in the examples DB
   3. Change the chart type to be area chart
   4. You should not get an error, instead, the filters should be populated 
using the new dataset info
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to