eschutho opened a new pull request, #23716: URL: https://github.com/apache/superset/pull/23716
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Redshift automatically converts all text columns to a varchar(256) which means for uploads, and in particular csv uploads for this case, the only way to upload a column with a large text field is to first create the table in sql lab with the correct column definitions and then upload to that existing table and replace the data. This pr adds a new dtype field for the upload, and using the "string" property, converts any field of this type to a varchar(max) for redshift. Currently all string types are uploaded as "object", so this change shouldn't impact any uploads that aren't explicitly passing the "string" property. We could extend this to other dbs, but it looks like the default behavior is for uploaded string columns to be converted to `text`. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
