[GitHub] [superset] kgabryje opened a new pull request, #23865: fix: Native time range filter in legacy charts

[via GitHub]

kgabryje opened a new pull request, #23865:
URL: https://github.com/apache/superset/pull/23865

   
   ### SUMMARY
   Some legacy charts (e.g. Heatmap and Bar Chart) were not getting dashboard 
time range filters applied with GENERIC_CHART_AXES enabled. This PR manually 
converts the time range into an adhoc filter, similarly how it's done for v1 
charts.
   
   Additionally, this PR brings back the time section for Calendar Heatmap 
chart, which was broken without it.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   <img width="1728" alt="image" 
src="https://user-images.githubusercontent.com/15073128/235162705-66399bd0-018f-4b63-bcae-24c7b13893f9.png";>
   
   After:
   
   <img width="1686" alt="image" 
src="https://user-images.githubusercontent.com/15073128/235162781-f6b90ff6-828d-41dd-8a0c-13678ccd53e3.png";>
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org