giftig commented on PR #21535: URL: https://github.com/apache/superset/pull/21535#issuecomment-1531086202
@eschutho thanks, I'll take a look at the updates around there and try to retest the issue we were having here. We're currently upgrading to the 2.1 release, and merging in the changes we had on our fork in order to do the upgrade. Unfortunately with some of those changes, like this one, I don't have an especially good idea of what the problem was, how the fix works, or whether the 2.1 release has independently fixed it, so I thought I'd check here and if this is fixed in the 2.1 release we can close this PR and it's one fewer commit to try to merge in. I put this one at the end of my list to test while I checked with you so if I'll try to verify the problem described here against 2.1 and if it's already fixed we can close this. Thanks @rusackas, I believe our product owner has already reached out to you and we have a call scheduled this week, so we'll speak shortly and I'll sign up to your slack as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
