giftig commented on PR #21535: URL: https://github.com/apache/superset/pull/21535#issuecomment-1535946176
@rusackas do you know who would be best to take a look at what's being done here? I see in git blame that several names have made major contributions to the SQL parse logic in this file. Obviously this is some of the most complex / low-level code so I'd like to get opinions on whether this fix is the "right" fix and what we can do to get this merged. Surprisingly I was able to cherry-pick this into 2.1 without any conflicts and am just retesting that the fix still works on our fork; it doesn't seem like the sql parse logic has changed much at all between 2.0 and 2.1. Hopefully this will make it easier to get this looked at and merged. Happy to make changes where needed and submit a new PR as Victor is no longer in our team and unlikely to be active here, and I notice your build is complaining about lack of test coverage in some parts / I'm sure someone on your team will have the context to come up with improvements for this fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
