Antonio-RiveroMartnez commented on code in PR #21838:
URL: https://github.com/apache/superset/pull/21838#discussion_r1183131371
##########
superset/databases/commands/test_connection.py:
##########
@@ -145,7 +152,7 @@ def ping(engine: Engine) -> bool:
)
# check for custom errors (wrong username, wrong password, etc)
errors = database.db_engine_spec.extract_errors(ex, context)
- raise DatabaseTestConnectionFailedError(errors) from ex
+ raise SupersetErrorsException(errors) from ex
Review Comment:
Hey @eschutho, the problem of doing that is that we would lost the `original
message` and instead the message from DatabaseTestConnectionFailedError would
be used (`Connection failed, please check your connection settings`) and not
the custom message with roles after parsing the original message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
