giftig commented on code in PR #21535: URL: https://github.com/apache/superset/pull/21535#discussion_r1188615440
########## superset/sql_parse.py: ########## @@ -187,6 +187,14 @@ def __eq__(self, __o: object) -> bool: class ParsedQuery: + class TableTuple(NamedTuple): + table: Table + level: int + + class AliasTuple(NamedTuple): + name: str + level: int Review Comment: As a fellow hater of Hungarian notation, I'd like to stress I'm not the original author :D I'll change these to something nicer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
