giftig commented on code in PR #21535:
URL: https://github.com/apache/superset/pull/21535#discussion_r1188650719
##########
tests/unit_tests/sql_parse_tests.py:
##########
@@ -525,6 +558,16 @@ def test_extract_tables_reusing_aliases() -> None:
with q1 as ( select key from q2 where key = '5'),
q2 as ( select key from src where key = '5')
select * from (select key from q1) a
+"""
+ )
+ == {Table("q2"), Table("src")}
+ )
Review Comment:
Not sure what the point of the extra CTE in the final SELECT was here, but
it didn't change the result for me either:
```sql
postgres=# WITH
result AS (SELECT * FROM hodor),
hodor AS (SELECT * FROM potatoes)
SELECT * FROM (SELECT * FROM result) final;
age | name
-----+-------
35 | Hodor
(1 row)
postgres=# WITH
result AS (SELECT * FROM hodor),
hodor AS (SELECT * FROM potatoes)
SELECT * FROM (SELECT age FROM result) final;
age
-----
35
(1 row)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
