villebro commented on code in PR #21535:
URL: https://github.com/apache/superset/pull/21535#discussion_r1193963718
##########
tests/unit_tests/sql_parse_tests.py:
##########
@@ -525,6 +558,16 @@ def test_extract_tables_reusing_aliases() -> None:
with q1 as ( select key from q2 where key = '5'),
q2 as ( select key from src where key = '5')
select * from (select key from q1) a
+"""
+ )
+ == {Table("q2"), Table("src")}
+ )
Review Comment:
Ok good to know, this is likely one of those cases where different dbs
behave differently. To support both use cases we could probably add a flag on
`BaseEngineSpec` that specifies which variant the db in question supports.
Something like `cte_forward_alias_reference` that we'd set to `False` for
SQLite and `True` for Postgres (we should probably do some additional testing
to see which is the more common flavor before setting that on `BaseEngineSpec`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
