github-code-scanning[bot] commented on code in PR #24197:
URL: https://github.com/apache/superset/pull/24197#discussion_r1203668397
##########
superset/views/core.py:
##########
@@ -300,13 +300,11 @@
datasources.add(datasource)
has_access_ = all(
- (
- datasource and
security_manager.can_access_datasource(datasource)
- for datasource in datasources
- )
+ datasource and security_manager.can_access_datasource(datasource)
+ for datasource in datasources
)
if has_access_:
- return redirect("/superset/dashboard/{}".format(dashboard_id))
+ return redirect(f"/superset/dashboard/{dashboard_id}")
Review Comment:
## URL redirection from remote source
Untrusted URL redirection depends on a [user-provided value](1).
[Show more
details](https://github.com/apache/superset/security/code-scanning/1202)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
