michael-s-molina commented on code in PR #24197:
URL: https://github.com/apache/superset/pull/24197#discussion_r1213494886
##########
superset/connectors/sqla/models.py:
##########
@@ -869,8 +858,8 @@ def get_sqla_table(self) -> TableClause:
return tbl
def get_from_clause(
- self, template_processor: Optional[BaseTemplateProcessor] = None
- ) -> Tuple[Union[TableClause, Alias], Optional[str]]:
+ self, template_processor: BaseTemplateProcessor | None = None
+ ) -> tuple[TableClause | Alias, str | None]:
Review Comment:
It's way more readable then the `Optional` version 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
