Antonio-RiveroMartnez commented on code in PR #24205:
URL: https://github.com/apache/superset/pull/24205#discussion_r1205872976
##########
superset-frontend/packages/superset-ui-core/src/ui-overrides/ExtensionsRegistry.ts:
##########
@@ -109,6 +109,27 @@ export interface DatabaseConnectionExtension {
onEdit?: (componentState: any) => void;
}
+/**
+ * Interface for extensions SQL Form.
+ * These will be passed from the SQLEditor
+ *
+ * You can specify the types to be used for these properties
+ * for better type checking or use the default ones.
+ *
+ * @template TTables - Type for the tables array.
+ * @template TQueryEditor - Type for the query editor.
+ * @template TDatabase - Type for the database.
+ */
+export interface SQLFormExtensionProps<
+ TTables = any[],
+ TQueryEditor = object,
+ TDatabase = any,
+> {
+ tables: TTables[];
+ queryEditor: TQueryEditor;
+ database: TDatabase;
Review Comment:
Hey @justinpark ! Good call, I will change this. I am working a bit more on
this extension feature so I'll move this PR to be a DRAFT until I get
everything in place and final props etc are figured out. ILYK. Thanks for the
input as always 👏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
