Antonio-RiveroMartnez commented on code in PR #24205:
URL: https://github.com/apache/superset/pull/24205#discussion_r1218584772
##########
superset-frontend/src/SqlLab/components/SqlEditor/index.jsx:
##########
@@ -673,6 +684,15 @@ const SqlEditor = ({
onDragEnd={onResizeEnd}
>
<div ref={northPaneRef} className="north-pane">
+ {SqlFormExtension && (
+ <SqlFormExtension
+ queryEditorId={queryEditor.id}
+ setQueryEditorAndSaveSqlWithDebounce={
Review Comment:
Hey @justinpark sure, I can recreate all those with the helpers, but since
we are not changing how they work, just invoking them, I treated them like
other props our existing extensions are using. IMHO I see no major benefit by
forcing a duplication of code in the extension. However, if you truly see this
like an scenario we should force such duplication, I can work on it in a follow
up PR. Thanks as always for the input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
