michael-s-molina commented on code in PR #24200:
URL: https://github.com/apache/superset/pull/24200#discussion_r1205932438
##########
docs/docs/databases/installing-database-drivers.mdx:
##########
@@ -22,8 +22,8 @@ A list of some of the recommended packages.
| Database | PyPI package
| Connection
String
|
| --------------------------------------------------------- |
----------------------------------------------------------------------------------
|
-----------------------------------------------------------------------------------------------------------
|
-| [Amazon Athena](/docs/databases/athena) | `pip install
"PyAthenaJDBC>1.0.9` , `pip install "PyAthena>1.2.0` |
`awsathena+rest://{aws_access_key_id}:{aws_secret_access_key}@athena.{region_name}.amazonaws.com/{
` |
-| [Amazon DynamoDB](/docs/databases/dynamodb) | `pip install
"PyDynamoDB>=0.4.2` |
`dynamodb://{access_key_id}:{secret_access_key}@dynamodb.{region_name}.amazonaws.com?connector=superset`
|
+| [Amazon Athena](/docs/databases/athena) | `pip install
"PyAthenaJDBC>1.0.9"` , `pip install "pyathena[pandas]>=2,<3"` |
`awsathena+rest://{aws_access_key_id}:{aws_secret_access_key}@athena.{region_name}.amazonaws.com/{
` |
Review Comment:
I believe it would be better if we treat this table as an example and point
the reader to the files where the most up to date versions can be found such as
`setup.py` and `requirements/*`. That way, this documentation will be more
resilient to version upgrades.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
