cwegener commented on code in PR #24200:
URL: https://github.com/apache/superset/pull/24200#discussion_r1210909281
##########
docs/docs/databases/installing-database-drivers.mdx:
##########
@@ -22,8 +22,8 @@ A list of some of the recommended packages.
| Database | PyPI package
| Connection
String
|
| --------------------------------------------------------- |
----------------------------------------------------------------------------------
|
-----------------------------------------------------------------------------------------------------------
|
-| [Amazon Athena](/docs/databases/athena) | `pip install
"PyAthenaJDBC>1.0.9` , `pip install "PyAthena>1.2.0` |
`awsathena+rest://{aws_access_key_id}:{aws_secret_access_key}@athena.{region_name}.amazonaws.com/{
` |
-| [Amazon DynamoDB](/docs/databases/dynamodb) | `pip install
"PyDynamoDB>=0.4.2` |
`dynamodb://{access_key_id}:{secret_access_key}@dynamodb.{region_name}.amazonaws.com?connector=superset`
|
+| [Amazon Athena](/docs/databases/athena) | `pip install
"PyAthenaJDBC>1.0.9"` , `pip install "pyathena[pandas]>=2,<3"` |
`awsathena+rest://{aws_access_key_id}:{aws_secret_access_key}@athena.{region_name}.amazonaws.com/{
` |
Review Comment:
@michael-s-molina
I tried looking into this issue once before. I couldn't figure out why this
table had been changed from referencing the optional extras requirements that
are managed in the setup.py to the state the table now is in where it no longer
specifies the optional extras requirements but instead directly lists the
actual driver package names in the documentation table itself.
I think there is a bigger question of how to manage the driver compatibility
and support in general. I.e. should the be such a concept of "officially
supported and tested drivers" that should have an expectation of always
working, vs community-supported and tested drivers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
