hughhhh commented on code in PR #24278:
URL: https://github.com/apache/superset/pull/24278#discussion_r1218290889
##########
Makefile:
##########
@@ -115,3 +115,21 @@ report-celery-beat:
admin-user:
superset fab create-admin
+
+# Create a postgres instance using docker
+# CLI: $ psql postgresql://postgres:1234@localhost:5432/postgres
+# superset_config.py: SQLALCHEMY_DATABASE_URI =
'postgresql://postgres:1234@localhost:5432/postgres'
+db:
+ # start postgres with detached mode
+ docker run -d -p 127.0.0.1:5432:5432 -e POSTGRES_PASSWORD="1234" --name
pg postgres:alpine;\
+ EXIT_CODE=$$?;\
+ echo $$EXIT_CODE;\
+ echo "command exited with $$EXIT_CODE";\
+ if [ $$EXIT_CODE -ne "0" ]; then docker start pg; echo "DB has been
created"; fi
Review Comment:
from my understanding docker compose is referencing a set of images in the
compose yaml vs this is just one image we are targeting
this recipes are mostly focused for codespaces and has been making my
workflow super easy. The idea i had hear was to make it a command to get the
api + client running on your computer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
