zhaoyongjie commented on code in PR #24278:
URL: https://github.com/apache/superset/pull/24278#discussion_r1218527230


##########
Makefile:
##########
@@ -115,3 +115,21 @@ report-celery-beat:
 
 admin-user:
        superset fab create-admin
+
+# Create a postgres instance using docker
+# CLI: $ psql postgresql://postgres:1234@localhost:5432/postgres
+# superset_config.py: SQLALCHEMY_DATABASE_URI = 
'postgresql://postgres:1234@localhost:5432/postgres'
+db:
+       # start postgres with detached mode
+       docker run -d -p 127.0.0.1:5432:5432 -e POSTGRES_PASSWORD="1234" --name 
pg postgres:alpine;\

Review Comment:
   > even if this is for development? I'm trying to make this super easy for 
people to spin up superset with one command, but if you really think we should 
have a way to configure the password let me know
   
   No, If you want to use it yourself, you can do it by yourself and local. If 
you publish it in a public codebase, please keep the basic security rules.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to