jfrag1 commented on code in PR #24301:
URL: https://github.com/apache/superset/pull/24301#discussion_r1220291590
##########
superset-frontend/src/SqlLab/types.ts:
##########
@@ -49,6 +49,7 @@ export interface QueryEditor {
selectedText?: string;
queryLimit?: number;
description?: string;
+ uuid: string | null;
Review Comment:
My understanding is that `uuid: string | null` means the key will always be
there, but may be null, and `uuid?: string` means that the key may or may not
be there, but if it is it's a string. This way seemed more accurate to me, I
copied from the type def for the `remoteId` here (which is the saved query
numerical id), since it should be the same for UUID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
