jfrag1 commented on code in PR #24301:
URL: https://github.com/apache/superset/pull/24301#discussion_r1221933270
##########
superset-frontend/src/SqlLab/components/ShareSqlLabQuery/index.tsx:
##########
@@ -76,10 +77,10 @@ const ShareSqlLabQuery = ({
const getCopyUrlForSavedQuery = (callback: Function) => {
let savedQueryToastContent;
- if (remoteId) {
+ if (uuid) {
savedQueryToastContent = `${
window.location.origin + window.location.pathname
- }?savedQueryId=${remoteId}`;
+ }?savedQueryId=${uuid}`;
Review Comment:
Existing URLs will still works just fine as the get saved query endpoint
still accepts numerical id's
##########
superset-frontend/src/SqlLab/components/ShareSqlLabQuery/index.tsx:
##########
@@ -76,10 +77,10 @@ const ShareSqlLabQuery = ({
const getCopyUrlForSavedQuery = (callback: Function) => {
let savedQueryToastContent;
- if (remoteId) {
+ if (uuid) {
savedQueryToastContent = `${
window.location.origin + window.location.pathname
- }?savedQueryId=${remoteId}`;
+ }?savedQueryId=${uuid}`;
Review Comment:
Existing URLs will still work just fine as the get saved query endpoint
still accepts numerical id's
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
