villebro commented on code in PR #24176: URL: https://github.com/apache/superset/pull/24176#discussion_r1223042935
########## superset/common/query_context_processor.py: ########## @@ -307,6 +324,40 @@ def _get_timestamp_format( return df + @staticmethod + def get_time_grain( + query_context: QueryContext, query_object: QueryObject + ) -> Any | None: + if query_context.form_data: + return query_context.form_data.get("time_grain_sqla") Review Comment: I understand the confusion this causes. I'll try to prepare a follow-up that moves the relevant info from form data into query context/object and removes form data all together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org