zhaoyongjie commented on PR #24176: URL: https://github.com/apache/superset/pull/24176#issuecomment-1583244689
@michael-s-molina I've made the following suggestions during the code review: 1. It would be better to keep this pull request focused on the necessary changes rather than including refactorings and unrelated fixes. Let's aim to minimize the scope of the PR. 2. We should avoid hard coding values without considering the maintainability for other engineers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
