john-bodley commented on code in PR #24546:
URL: https://github.com/apache/superset/pull/24546#discussion_r1245735651
##########
superset-frontend/src/pages/ChartList/index.tsx:
##########
@@ -287,9 +287,7 @@ function ChartList(props: ChartListProps) {
...filters,
});
const response: void | JsonResponse = await SupersetClient.get({
- endpoint: !filterValue
- ? `/api/v1/dashboard/?q=${queryParams}`
- : `/api/v1/chart/?q=${queryParams}`,
+ endpoint: `/api/v1/dashboard/?q=${queryParams}`,
Review Comment:
@michael-s-molina I briefly looked into this logic previously. Could you
confirm that your logic also works when you include a `filterValue`. i.e., text
in the `SEARCH` box?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
