michael-s-molina commented on code in PR #24546:
URL: https://github.com/apache/superset/pull/24546#discussion_r1245772035
##########
superset-frontend/src/pages/ChartList/index.tsx:
##########
@@ -287,9 +287,7 @@ function ChartList(props: ChartListProps) {
...filters,
});
const response: void | JsonResponse = await SupersetClient.get({
- endpoint: !filterValue
- ? `/api/v1/dashboard/?q=${queryParams}`
- : `/api/v1/chart/?q=${queryParams}`,
+ endpoint: `/api/v1/dashboard/?q=${queryParams}`,
Review Comment:
If you use the search input (not the dashboard select) to look for a
dashboard name, it won't work. That would require creating a [search
filter](https://github.com/apache/superset/blob/83ff4cd86a4931fc8eda83aeb3d8d3c92d773202/superset/charts/filters.py#L133)
but that's out of the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
