john-bodley opened a new pull request, #24607: URL: https://github.com/apache/superset/pull/24607
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY This a a fast follow to https://github.com/apache/superset/pull/24466 which condensed the delete/bulk-delete DAO operations. Specifically it condenses the delete/bulk-delete commands into a single operation which helps to ensure we adhere to the DRY principle. Though the change maybe somewhat difficult to grok from a GitHub diff perspective the logic is as follows. If there exists `commands/bulk_delete.py` and optionally `commands/delete.py` file, then: 1. Delete the `commands/delete.py` file. 2. Rename `commands/bulk_delete.py` to `commands/delete.py`. 3. Rename `BulkDelete...` to `Delete...` for commands, exceptions, etc. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS CI. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
