michael-s-molina commented on code in PR #24607: URL: https://github.com/apache/superset/pull/24607#discussion_r1261727779
########## superset/dashboards/commands/exceptions.py: ########## @@ -51,15 +51,7 @@ def __init__( class DashboardCreateFailedError(CreateFailedError): - message = _("Dashboard could not be created.") - - -class DashboardBulkDeleteFailedError(CreateFailedError): - message = _("Dashboards could not be deleted.") - - -class DashboardBulkDeleteFailedReportsExistError(DashboardBulkDeleteFailedError): - message = _("There are associated alerts or reports") + message = _("Dashboard(s) could not be created.") Review Comment: John, I'm not sure if I understood. My suggestion is to follow the comment you referenced. Notice that your change is in the form `Dashboard(s)` but I'm suggesting to use `Dashboards`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org