zephyring commented on code in PR #24630:
URL: https://github.com/apache/superset/pull/24630#discussion_r1258602877
##########
superset/charts/commands/create.py:
##########
@@ -69,6 +71,9 @@ def validate(self) -> None:
dashboards = DashboardDAO.find_by_ids(dashboard_ids)
if len(dashboards) != len(dashboard_ids):
exceptions.append(DashboardsNotFoundValidationError())
+ for dash in dashboards:
+ if not security_manager.is_owner(dash):
+ raise DashboardsForbiddenError()
Review Comment:
I wonder if we should return DashboardsNotFoundValidationError as otherwise
it can be exploit to validate this dashboard id does exist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
