michael-s-molina commented on code in PR #24630:
URL: https://github.com/apache/superset/pull/24630#discussion_r1258683095
##########
tests/integration_tests/charts/api_tests.py:
##########
@@ -560,6 +560,31 @@ def test_create_chart_validate_datasource(self):
response, {"message": {"datasource_id": ["Datasource does not
exist"]}}
)
+ @pytest.mark.usefixtures("load_world_bank_dashboard_with_slices")
+ def test_create_chart_validate_user_is_dashboard_owner(self):
+ """
+ Chart API: Test create validate user is dashboard owner
+ """
+ dash =
db.session.query(Dashboard).filter_by(slug="world_health").first()
+ # Must be published so that alpha user has read access to dash
+ dash.published = True
Review Comment:
Won't this change break test idempotency? Do we need to rollback the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
