john-bodley opened a new pull request, #24675: URL: https://github.com/apache/superset/pull/24675
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Whilst working on https://github.com/apache/superset/pull/24671 I realize that some non-legacy charts (which are invoked via the `/api/v1/chart` RESTful API endpoint) are still present in `superset.viz` meaning the logic outlined in said PR for differentiating between legacy and non-legacy charts was incorrect. This PR removes the following charts (which were marked as deprecated in 3.0 though in actuality were obsolete): - `TableViz` - `BigNumberViz` - `BigNumberTotalViz` which will ensure that the logic in https://github.com/apache/superset/pull/24671 will be correct. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS I systematically went through all the visualization types in `superset/viz.py` (all NVD3 and DeckGL charts were bucketed together) and inspected which RESTful API endpoint was being invoked, i.e., any chart using the RESTful `/superset/explore_json` endpoint (or similar) remained. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
