john-bodley commented on code in PR #24675:
URL: https://github.com/apache/superset/pull/24675#discussion_r1261689296
##########
tests/integration_tests/charts/api_tests.py:
##########
@@ -1715,7 +1715,7 @@ def test_gets_owned_created_favorited_by_me_filter(self):
)
def test_warm_up_cache(self):
self.login()
- slc = self.get_slice("Girls", db.session)
+ slc = self.get_slice("Top 10 Girl Name Share", db.session)
Review Comment:
Currently caching only works with legacy charts and removal of the
`TableViz` now treats the `Girls` chart as a non-legacy chart. One could argue
this is a regression—in terms of fewer charts being eligible for caching—but
the problem will be rectified in https://github.com/apache/superset/pull/24671.
##########
tests/integration_tests/charts/api_tests.py:
##########
@@ -1715,7 +1715,7 @@ def test_gets_owned_created_favorited_by_me_filter(self):
)
def test_warm_up_cache(self):
self.login()
- slc = self.get_slice("Girls", db.session)
+ slc = self.get_slice("Top 10 Girl Name Share", db.session)
Review Comment:
Currently caching only works with legacy charts and removal of the
`TableViz` now treats the `Girls` chart as a non-legacy chart. One could argue
this is a regression—in terms of fewer charts being eligible for caching—but
the problem will be rectified in https://github.com/apache/superset/pull/24671.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
