kasiazjc commented on PR #24736: URL: https://github.com/apache/superset/pull/24736#issuecomment-1642523892
> @kasiazjc @mistercrunch Could we try something that does not include the `<hr>`? For me, these additional lines kind of conflict with the collapsible panel lines. Maybe keep the bold and improve spacing? @michael-s-molina I know that it's not perfect, but the line is a temp solution until we get rid of the upper case in labels (and in general in the app). With the current implementation and the number of different components and font sizes it's not easy to define a clear and easy hierarchy. We had a version with line and without a line, and it seems for now the line makes the most sense (from the feedback I got), but curious to hear your opinion. Side by side mocks below: <img width="1209" alt="image" src="https://github.com/apache/superset/assets/36897697/e78aa7e1-97d9-4124-8bcb-640631fafa45";> <img width="1209" alt="image" src="https://github.com/apache/superset/assets/36897697/7aca8e63-8491-4ee0-9a48-8e615bddc395";> note - there is one thing that needs to be changed in the current implementation - the color of the text in the subheader to #666666, because black is overpowering. What is the perfect case scenario is this version - labels are sentence case and there is no line below subheader, but it's sadly not something that we can take up right now <img width="1209" alt="image" src="https://github.com/apache/superset/assets/36897697/8f65c66a-84b0-4efe-9e13-5a76576a6866";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
