john-bodley commented on PR #24736: URL: https://github.com/apache/superset/pull/24736#issuecomment-1642612484
+1 on @michael-s-molina's https://github.com/apache/superset/pull/24736#issuecomment-1642573597. I don't disagree that the UX could be improved (see [SIP-82](https://github.com/apache/superset/issues/20159) for details) but I'm not sure the proposal outlined in this PR actually makes things clearer. I actuality I think it makes things more convoluted, i.e., granted there's a margin around the horizontal lines, but I could perceive users being confused around the chevron behavior, i.e., for <img width="289" alt="Screenshot 2023-07-19 at 12 07 43 PM" src="https://github.com/apache/superset/assets/4567245/3331cd7b-64e8-49c4-bc20-e2ac498d65ee";> it's not overly apparent what will be collapsed when one would close the `Advanced analytics` section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
