[GitHub] [superset] mistercrunch commented on a diff in pull request #24747: fix: update svgr webpack config to use svg dimensions

[via GitHub]

mistercrunch commented on code in PR #24747:
URL: https://github.com/apache/superset/pull/24747#discussion_r1269961036


##########
superset-frontend/webpack.config.js:
##########
@@ -419,11 +419,6 @@ const config = {
           {
             loader: '@svgr/webpack',
             options: {
-              icon: true,

Review Comment:
   are the defaults good? do we want to be explicit as in
   ```javascript
   options: {
     // making sure that svgo isn't setting width:1em
     icon: false,
     // don't allow svgo to alter/opitmize the svg 
     svgo: false,
   },
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org