eschutho commented on PR #24747:
URL: https://github.com/apache/superset/pull/24747#issuecomment-1644621820

   > @eschutho do you see #24740? It seems @mistercrunch had an alternative 
formulation.
   
   Thanks @john-bodley, yeah I saw @mistercrunch's PR as well. This PR just 
reverts the functionality back to the original behavior where it does not 
override the width/height if it's in the svg file.  @mistercrunch, @rusackas 
and I talked a bit offline  about what the long-term behavior should be and 
agreed that we'll merge both PRs with the idea that if you wanted to use 
height/width in the svg that it should render in the html, or if you want to 
override the values with css, you can do that as well. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to